Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI: require all bodies in client-server #3238

Merged
merged 1 commit into from Aug 5, 2021
Merged

OpenAPI: require all bodies in client-server #3238

merged 1 commit into from Aug 5, 2021

Conversation

lukaslihotzki
Copy link
Contributor

Fix #3237

@KitsuneRal
Copy link
Member

I guess a changelog entry is needed to merge this but @turt2live knows better.

@lukaslihotzki
OpenAPI: require all bodies in client-server
7d0e931 
Signed-off-by: Lukas Lihotzki <lukas@lihotzki.de>
@turt2live turt2live self-requested a review July 28, 2021 14:02
@reivilibre reivilibre mentioned this pull request Aug 4, 2021
Closed
turt2live
turt2live approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! This does indeed need a changelog because it ultimately affects the rendered spec.

@turt2live turt2live merged commit c651d39 into matrix-org:master Aug 5, 2021
@lukaslihotzki lukaslihotzki mentioned this pull request Aug 11, 2021
Merged
richvdh pushed a commit that referenced this pull request Aug 23, 2021
@turt2live @richvdh
Merge pull request #3238 from lukaslihotzki/required-bodies
7c407e9 
OpenAPI: require all bodies in client-server
richvdh pushed a commit that referenced this pull request Aug 27, 2021
@turt2live @richvdh
Merge pull request #3238 from lukaslihotzki/required-bodies
cdcc24a 
OpenAPI: require all bodies in client-server
Dominaezzz added a commit to Dominaezzz/matrix-kt that referenced this pull request Nov 14, 2021
@Dominaezzz
All request bodies are now required.
12e23a6 
See matrix-org/matrix-spec-proposals#3238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@richvdh richvdh richvdh approved these changes

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional body parameters
4 participants
@lukaslihotzki @KitsuneRal @turt2live @richvdh