Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/_matrix/federation/v1/user/devices/{userId}: Rename self_signing_keys to self_signing_key #3312

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

neilalexander
Copy link
Contributor

Apparently, in response to a /_matrix/federation/v1/user/devices/{userId} request, Synapse actually returns a key called "self_signing_key" instead of "self_signing_keys".

@neilalexander neilalexander requested a review from a team August 5, 2021 10:24
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a changelog entry plskthx

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

changelogs/server_server/newsfragments/3312.clarification Outdated Show resolved Hide resolved
@richvdh richvdh merged commit 729812f into master Aug 5, 2021
@neilalexander neilalexander deleted the neilalexander/selfsigningkey branch August 5, 2021 10:49
richvdh pushed a commit that referenced this pull request Aug 23, 2021
…keys` to `self_signing_key` (#3312)

Apparently, in response to a /_matrix/federation/v1/user/devices/{userId} request, Synapse actually returns a key called "self_signing_key" instead of "self_signing_keys".
richvdh pushed a commit that referenced this pull request Aug 27, 2021
…keys` to `self_signing_key` (#3312)

Apparently, in response to a /_matrix/federation/v1/user/devices/{userId} request, Synapse actually returns a key called "self_signing_key" instead of "self_signing_keys".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants