Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in /_matrix/client/r0/account/3pid/delete (indentity -> identity). #3339

Merged
merged 1 commit into from Aug 16, 2021

Conversation

dkasak
Copy link
Member

@dkasak dkasak commented Aug 16, 2021

No description provided.

@dkasak dkasak merged commit 10f1a12 into master Aug 16, 2021
@uhoreg
Copy link
Member

uhoreg commented Aug 16, 2021

@dkasak changes to the spec generally need a changelog entry to be added in changelogs/*/newsfragments/. For changes such as this, use the text "Fix various typos throughout the specification." so that all typo fixes get grouped together.

@dkasak
Copy link
Member Author

dkasak commented Aug 16, 2021

Noted, thank you. I'll add a newsfragment separately tomorrow.

What type should typo fixes be? Is this a "clarification"?

@turt2live
Copy link
Member

Yes, it would be a clarification. In general, the spec core team should be requested for review of all PRs just to make sure it's a complete solution.

dkasak added a commit that referenced this pull request Aug 17, 2021
@dkasak dkasak deleted the dkasak/fix-typo-indentity branch August 17, 2021 08:29
richvdh pushed a commit that referenced this pull request Aug 17, 2021
richvdh pushed a commit that referenced this pull request Aug 23, 2021
Fix typo in /_matrix/client/r0/account/3pid/delete (indentity -> identity).
richvdh pushed a commit that referenced this pull request Aug 23, 2021
richvdh pushed a commit that referenced this pull request Aug 27, 2021
Fix typo in /_matrix/client/r0/account/3pid/delete (indentity -> identity).
richvdh pushed a commit that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants