Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate PDU terms from their definitions #3527

Merged
merged 2 commits into from Feb 1, 2022

Conversation

devonh
Copy link
Contributor

@devonh devonh commented Nov 25, 2021

Signed-off-by: Devon Hudson devonhudson@librem.one

Currently on the new spec site the definitions section on S-S PDUs has no clear distinction between the terms and their definitions.
This PR adds a distinction between them.

Preview: https://pr3527--matrix-org-previews.netlify.app

Signed-off-by: Devon Hudson <devonhudson@librem.one>
@richvdh richvdh requested a review from a team November 25, 2021 12:24
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Can we get a changelog which copies the "Fix various typos throughout the specification" entries we have... somewhere?

@anoadragon453
Copy link
Member

Going to pop a changelog on this and merge ahead of the v1.2 release.

@anoadragon453 anoadragon453 merged commit fc5ba95 into matrix-org:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants