Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search API lies and claims that it takes a v2 filter (SPEC-301) #598

Closed
matrixbot opened this issue Dec 11, 2015 · 2 comments
Closed

search API lies and claims that it takes a v2 filter (SPEC-301) #598

matrixbot opened this issue Dec 11, 2015 · 2 comments
Assignees
@turt2live
Labels
p2 spec-bug Something which is in the spec, but is wrong
Projects
August 2018 r0

Comments

@matrixbot
Copy link
Member

it actually takes a subset of one: the timeline(?) subkey of a v2 filter.

(Imported from https://matrix.org/jira/browse/SPEC-301)

(Reported by @ara4n)
@matrixbot
Copy link
Member Author

Jira watchers: @ara4n

@matrixbot matrixbot added the p2 label Oct 28, 2016
@matrixbot matrixbot changed the title search API lies and claims that it takes a v2 filter search API lies and claims that it takes a v2 filter (SPEC-301) Oct 31, 2016
@matrixbot matrixbot added the spec-bug Something which is in the spec, but is wrong label Nov 7, 2016
@jimmycuadra
Copy link
Contributor

Can this be clarified? Is the value of the filter field supposed to be like this:

{
  "timeline": {
    "foo": "bar"
  }
}

or like this:

{
  "foo": "bar"
}

?

@jimmycuadra jimmycuadra mentioned this issue Jun 6, 2018
Open
@turt2live turt2live added this to To do: client-server (prioritized) in August 2018 r0 Aug 14, 2018
@turt2live turt2live self-assigned this Aug 27, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 27, 2018
@turt2live
Specify the type of filter the search API expects
5fa6b49 
Note: This is badly named until matrix-org#1570 lands

Fixes matrix-org#598
@turt2live turt2live mentioned this issue Aug 27, 2018
Merged
@turt2live turt2live moved this from To do: client-server (prioritized) to In review (just the issues) in August 2018 r0 Aug 27, 2018
August 2018 r0 automation moved this from In review (just the issues) to Done (this list will be incomplete) Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
p2 spec-bug Something which is in the spec, but is wrong
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimmycuadra @turt2live @matrixbot