Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CS API: Using type:number for the notifications limit #746

Closed
KitsuneRal opened this issue Nov 29, 2016 · 0 comments
Closed

CS API: Using type:number for the notifications limit #746

KitsuneRal opened this issue Nov 29, 2016 · 0 comments
Labels
clarification An area where the spec could do with being more explicit tools Related to the process and tools for building the spec
Projects
August 2018 r0

Comments

@KitsuneRal
Copy link
Member

In api/client-server/notifications.yaml, I see that type: number is used for the limit parameter. As far as I understand Swagger, shouldn't it rather be type: integer? numbers seem to rather be used for non-integer numbers.
@turt2live turt2live added clarification An area where the spec could do with being more explicit tools Related to the process and tools for building the spec labels Jul 19, 2018
@turt2live turt2live added this to To do: client-server (prioritized) in August 2018 r0 Aug 14, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 27, 2018
@turt2live
Replace applicable types of 'number' to 'integer'
de42921 
`number` implies/represents a float where `integer` does not.

The only remaining `type: number` in the project appear on power levels: those have been left untouched pending clarification.

Fixes matrix-org#746
@turt2live turt2live moved this from To do: client-server (prioritized) to In review (just the issues) in August 2018 r0 Aug 27, 2018
@turt2live turt2live mentioned this issue Aug 27, 2018
Merged
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 27, 2018
@turt2live
Replace applicable types of 'number' to 'integer'
667fa08 
`number` implies/represents a float where `integer` does not.

The only remaining `type: number` in the project appear on power levels: those have been left untouched pending clarification.

Fixes matrix-org#746
August 2018 r0 automation moved this from In review (just the issues) to Done (this list will be incomplete) Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification An area where the spec could do with being more explicit tools Related to the process and tools for building the spec
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @KitsuneRal