Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list of event keys to preserve on redactions is incomplete #839

Closed
richvdh opened this issue Mar 16, 2017 · 0 comments
Closed

list of event keys to preserve on redactions is incomplete #839

richvdh opened this issue Mar 16, 2017 · 0 comments
Assignees
@turt2live
Labels
spec-bug Something which is in the spec, but is wrong
Projects
August 2018 r0

Comments

@richvdh
Copy link
Member

richvdh commented Mar 16, 2017

We should preserve origin_server_ts. Also, prev_content is in unsigned nowadays; we should say so. Also - the list given is correct for the C-S API, but it says it should be done by the server: there are other keys (hashes, signatures, origin, etc) which should be preserved by the server.
@richvdh richvdh added the spec-bug Something which is in the spec, but is wrong label Oct 16, 2017
@turt2live turt2live added this to To do: cross-cutting/misc (prioritized) in August 2018 r0 Aug 14, 2018
@turt2live turt2live self-assigned this Aug 28, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 29, 2018
@turt2live
Add the other fields the server is expected to keep on events
348b549 
Fixes matrix-org#839

Reference: https://github.com/matrix-org/synapse/blob/d69decd5c78c72abef50b597a689e2bc55a39702/synapse/events/utils.py#L44-L91
@turt2live turt2live mentioned this issue Aug 29, 2018
Merged
@turt2live turt2live moved this from To do: cross-cutting/misc (prioritized) to In review (just the issues) in August 2018 r0 Aug 29, 2018
August 2018 r0 automation moved this from In review (just the issues) to Done (this list will be incomplete) Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
spec-bug Something which is in the spec, but is wrong
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @richvdh