Document that clients must leave before forgetting rooms #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd also document what happens if one tries to forget a joined room (as far as I remember, the server returns 200 without doing anything), as this is by no means obvious. |
|
Added. Turns out synapse returns a 400 Bad Request with M_UNKNOWN. |
|
Huh, not the best thing. Still better that way, thank you. |
KitsuneRal
approved these changes
Jul 5, 2018
dbkr
approved these changes
Jul 5, 2018
|
(just fixed the changelog merge conflict - merging assuming the build passes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1011
This PR documents existing behaviour and does not attempt to improve or change the situation.
Reference: matrix-org/synapse#673