Spec for calculating display names for rooms and users #145
Conversation
|
@kegsay, fancy taking a look at this? |
| event. | ||
| #. If the room has an `m.room.canonical_alias`_ state event, use the alias | ||
| given by that event. | ||
| #. If neither of the above events are present, a name should be composed based/sys/class/backlight/intel_backlight/brightness |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Clients may wish to show the human-readable display name of the room member who | ||
| send a message, and in lists of room members. However, different members may |
There was a problem hiding this comment.
This sentence doesn't really make sense. I know what you mean, but the wording could be improved. Perhaps:
Clients may wish to show the display name of a room member as part of a membership list or when they send a message.
|
Reviewed: overall it is really good, we should absolutely be including this information until we can sort out server-side name generation. Unfortunately the whole problem of client-side generation is somewhat gnarly to explain, so I've done a lot of wording tweaks here and there which I feel simplifies the explanation. Please do counter if you feel they aren't explaining it any better. |
|
Thanks for the feedback, @kegsay. All useful stuff, most of which I agree with. There are a few points which still need nailing down - at some point in the future if not now:
My inclination is to open spec bugs on these, for now. |
| part of a membership list, or when they send a message. However, different | ||
| members may have conflicting display names. Display names MUST be disambiguated | ||
| before showing them to the user, in order to prevent spoofing of other users. | ||
|
|
There was a problem hiding this comment.
The intention here for the MUST would be only if the app hides the user ID. If apps show the user ID, then they should not be forced to apply disambiguation rules by the MUST here. Some clarification would be good.
There was a problem hiding this comment.
Hrm. Display names MUST be disambiguated [somehow] before showing them to the user. Clients SHOULD use this algorithm to do so. I'm not sure there is a problem.
There was a problem hiding this comment.
Good point; didn't see the SHOULD on the algorithm. LGTM
Raised https://matrix.org/jira/browse/SPEC-267
https://matrix.org/jira/browse/SPEC-221
|
|
LGTM other than #145 (comment) |
|
LGTM |
|
Thanks! |
We can at least spec the algorithm, even if it's a pita to implement right now.