Reject events with superfluous auth_events entries #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's fine. A link would help though. Put in an anchor in the relevant place; s/described previously/described above/; make |
erikjohnston
force-pushed
the
erikj/limit_auth_events
branch
from
06ff696
to
080845a
Compare
|
I've added a link, though its not linking "above" as I couldn't figure out how to have a different link text? |
you can use a substitution, which involves wrapping with |
August 2018 r0
automation
moved this from In review (just the PRs)
to Reviewer approved
Aug 31, 2018
richvdh
approved these changes
Aug 31, 2018
August 2018 r0
automation
moved this from Reviewer approved
to Done (this list will be incomplete)
Aug 31, 2018
turt2live
added a commit
that referenced
this pull request
May 13, 2020
Fixes #2307 These restrictions are due to a Synapse change which never made it to the spec prior to the MSC process. This is therefore documenting an omission. Synapse's numbers are verified here: https://github.com/matrix-org/synapse/blob/207b1737ee0acd226359d59ce3b7f7d46111b1c8/synapse/handlers/federation.py#L1183-L1213 ... and Synapse's handling of the backfill endpoint is described here: https://github.com/matrix-org/synapse/blob/207b1737ee0acd226359d59ce3b7f7d46111b1c8/synapse/handlers/federation.py#L829-L837 This also includes a mention that #1594 should render the `auth_events` limitation unnecessary. No changes are required to the the "checks on receipt of a PDU" section of the server-server spec as it starts with "must be a valid event", to which an event is invalid if it contains too many prev or auth events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #1591, #1592
Related: #1593
Its a bit annoying that this refers to an algorithm from a previous section, but I don't want to duplicate it. Thoughts on how to tidy this up?