Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that FAIL_ERROR is not limited to just homeservers. #2036

Merged
merged 1 commit into from May 30, 2019
Merged

Clarify that FAIL_ERROR is not limited to just homeservers. #2036

merged 1 commit into from May 30, 2019

Conversation

turt2live
Copy link
Member

Fixes #1735

@turt2live turt2live requested a review from a team May 28, 2019 04:30
KitsuneRal
KitsuneRal reviewed May 28, 2019
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implying things like media servers?

@turt2live
Copy link
Member Author

Media servers aren't a thing. This is scoped to discovery already.

@turt2live turt2live requested a review from KitsuneRal May 28, 2019 13:27
@turt2live turt2live added the Matrix 1.0 Spec PRs that need review for 1.0 label May 29, 2019
@turt2live turt2live merged commit ff768ec into master May 30, 2019
@turt2live turt2live deleted the travis/1.0/wk-fail-error branch May 30, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg approved these changes

@KitsuneRal KitsuneRal Awaiting requested review from KitsuneRal

Assignees
No one assigned
Labels
Matrix 1.0 Spec PRs that need review for 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.well-known says to FAIL_ERROR in some identity server cases, but FAIL_ERROR is explicitly for homeservers
3 participants
@turt2live @uhoreg @KitsuneRal