Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2229: Allowing 3PID Owners to Rebind #2229

Merged
merged 12 commits into from Aug 19, 2019
Merged

MSC2229: Allowing 3PID Owners to Rebind #2229

merged 12 commits into from Aug 19, 2019

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Aug 12, 2019 •
edited

@anoadragon453 anoadragon453 changed the title MSC XXXX: Allowing 3PID Owners to Rebind MSC 2229: Allowing 3PID Owners to Rebind Aug 13, 2019
@anoadragon453 anoadragon453 marked this pull request as ready for review August 13, 2019 10:30
@anoadragon453 anoadragon453 added proposal A matrix spec change proposal proposal-in-review labels Aug 13, 2019
@anoadragon453
Copy link
Member Author

Thanks @dbkr. Putting this to a proposal of FCP:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Aug 13, 2019 •
edited by uhoreg

Team member @anoadragon453 has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Aug 13, 2019
@turt2live turt2live changed the title MSC 2229: Allowing 3PID Owners to Rebind MSC2229: Allowing 3PID Owners to Rebind Aug 13, 2019
@turt2live turt2live self-requested a review August 13, 2019 14:11
turt2live
turt2live approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sane to me overall

proposals/2229-rebind-existing-3pid.md
# Allowing 3PID Owners to Rebind

```
3PID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why we have these definitions here... they are fairly well described in the spec, surely?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make it easier for random people to come in and understand the document.

proposals/2229-rebind-existing-3pid.md Show resolved Hide resolved
proposals/2229-rebind-existing-3pid.md Outdated Show resolved Hide resolved
proposals/2229-rebind-existing-3pid.md Outdated Show resolved Hide resolved
proposals/2229-rebind-existing-3pid.md Outdated Show resolved Hide resolved
@ara4n
Copy link
Member

ara4n commented Aug 14, 2019

seems sane to me. worth noting that this isn't a strong restriction being relaxed, given bindings can be managed by talking directly to the IS, but just sanity checks imposed (or not) by the HS.

KitsuneRal
KitsuneRal approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one typo, I'm good

proposals/2229-rebind-existing-3pid.md Outdated Show resolved Hide resolved
proposals/2229-rebind-existing-3pid.md Show resolved Hide resolved
@anoadragon453 @KitsuneRal
Update proposals/2229-rebind-existing-3pid.md
4059661 
Co-Authored-By: Kitsune Ral <Kitsune-Ral@users.sf.net>
@mscbot
Copy link
Collaborator

mscbot commented Aug 14, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@jryans jryans added phase:1 privacy-sprint Temporary label: privacy-related stuff and removed phase:1 labels Aug 15, 2019
This was referenced Aug 15, 2019
Merged
Closed
@mscbot
Copy link
Collaborator

mscbot commented Aug 19, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot removed the final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. label Aug 19, 2019
@anoadragon453 anoadragon453 merged commit 997c546 into master Aug 19, 2019
@anoadragon453 anoadragon453 deleted the anoa/rebind_3pids branch August 19, 2019 12:35
@turt2live turt2live self-assigned this Aug 26, 2019
@turt2live turt2live added this to Implementation stages in Client-server r0.6 proposals Aug 26, 2019
@turt2live turt2live removed their assignment Aug 27, 2019
@jryans jryans mentioned this pull request Sep 6, 2019
Closed
@turt2live
Copy link
Member

Implementation: matrix-org/synapse#5996

@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Sep 9, 2019
@turt2live turt2live moved this from Implementation stages to Needs spec in Client-server r0.6 proposals Sep 9, 2019
@turt2live turt2live assigned turt2live and unassigned turt2live Sep 9, 2019
@turt2live turt2live removed this from Needs spec in Client-server r0.6 proposals Sep 11, 2019
@anoadragon453
Copy link
Member Author

This MSC has been made obselete by #2290

@turt2live turt2live added obsolete A proposal which has been overtaken by other proposals and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Sep 13, 2019
@jryans jryans added phase:1 and removed phase:2 labels Sep 18, 2019
@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@jryans jryans jryans approved these changes

@dbkr dbkr dbkr approved these changes

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees
No one assigned
Labels
disposition-merge kind:feature MSC for not-core and not-maintenance stuff obsolete A proposal which has been overtaken by other proposals privacy-sprint Temporary label: privacy-related stuff proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@anoadragon453 @mscbot @ara4n @turt2live @jryans @dbkr @KitsuneRal