Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2229: Allowing 3PID Owners to Rebind #2229

Merged
merged 12 commits into from Aug 19, 2019

Conversation

@anoadragon453
Copy link
Member

commented Aug 12, 2019

wip

@anoadragon453 anoadragon453 changed the title MSC XXXX: Allowing 3PID Owners to Rebind MSC 2229: Allowing 3PID Owners to Rebind Aug 13, 2019

@anoadragon453 anoadragon453 marked this pull request as ready for review Aug 13, 2019

@dbkr
dbkr approved these changes Aug 13, 2019
@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Thanks @dbkr. Putting this to a proposal of FCP:

@mscbot fcp merge

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

Team member @anoadragon453 has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@jryans
jryans approved these changes Aug 13, 2019

@turt2live turt2live changed the title MSC 2229: Allowing 3PID Owners to Rebind MSC2229: Allowing 3PID Owners to Rebind Aug 13, 2019

@turt2live turt2live self-requested a review Aug 13, 2019

@turt2live
Copy link
Member

left a comment

seems sane to me overall

# Allowing 3PID Owners to Rebind

```
3PID

This comment has been minimized.

Copy link
@turt2live

turt2live Aug 13, 2019

Member

not sure why we have these definitions here... they are fairly well described in the spec, surely?

This comment has been minimized.

Copy link
@anoadragon453

anoadragon453 Aug 13, 2019

Author Member

Just to make it easier for random people to come in and understand the document.

proposals/2229-rebind-existing-3pid.md Show resolved Hide resolved
proposals/2229-rebind-existing-3pid.md Outdated Show resolved Hide resolved
proposals/2229-rebind-existing-3pid.md Outdated Show resolved Hide resolved
proposals/2229-rebind-existing-3pid.md Outdated Show resolved Hide resolved
anoadragon453 and others added 5 commits Aug 13, 2019
Update proposals/2229-rebind-existing-3pid.md
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Update proposals/2229-rebind-existing-3pid.md
Co-Authored-By: Travis Ralston <travpc@gmail.com>
@ara4n

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

seems sane to me. worth noting that this isn't a strong restriction being relaxed, given bindings can be managed by talking directly to the IS, but just sanity checks imposed (or not) by the HS.

@KitsuneRal
Copy link
Member

left a comment

Aside from one typo, I'm good

proposals/2229-rebind-existing-3pid.md Outdated Show resolved Hide resolved
proposals/2229-rebind-existing-3pid.md Show resolved Hide resolved
Update proposals/2229-rebind-existing-3pid.md
Co-Authored-By: Kitsune Ral <Kitsune-Ral@users.sf.net>
@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 19, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@anoadragon453 anoadragon453 merged commit 997c546 into master Aug 19, 2019

8 checks passed

buildkite/matrix-doc Build #663 passed (1 minute, 14 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@anoadragon453 anoadragon453 deleted the anoa/rebind_3pids branch Aug 19, 2019

@turt2live turt2live self-assigned this Aug 26, 2019

@turt2live turt2live added this to Implementation stages in Client-server r0.6 proposals Aug 26, 2019

@turt2live turt2live removed their assignment Aug 27, 2019

@turt2live

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Implementation: matrix-org/synapse#5996

@turt2live turt2live moved this from Implementation stages to Needs spec in Client-server r0.6 proposals Sep 9, 2019

@turt2live turt2live assigned turt2live and unassigned turt2live Sep 9, 2019

@turt2live turt2live removed this from Needs spec in Client-server r0.6 proposals Sep 11, 2019

@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

This MSC has been made obselete by #2290

@turt2live turt2live added obsolete and removed spec-pr-missing labels Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.