Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix oapi3'ism in identity service #2238

Closed
wants to merge 1 commit into from
Closed

Conversation

saces
Copy link

@saces saces commented Aug 19, 2019

range definition for response codes is an oapi3 feature.
it goes without warning with this patch,
may the experts decide about the numbers to use ;)

@anoadragon453
Copy link
Member

The context is that having 3xx instead of 300 can break some tools processing our spec.

I believe we use 400 to mean 4xx in other places of the spec, so this doesn't seem entirely unreasonable a change.

@turt2live
Copy link
Member

We use the 2xx format elsewhere in the spec. I'm tempted to just call it part of our "extensions" for when we switch to OpenAPI 3.

@KitsuneRal
Copy link
Member

I'd also just dub it one more extension and consider it one more small nudge towards OpenAPI 3 migration.

@turt2live
Copy link
Member

I've opened the documentation as #2561

@turt2live turt2live closed this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants