Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend that clients don't preview URLs in encrypted rooms #2343

Merged
merged 2 commits into from Nov 6, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Nov 4, 2019

Any stronger of a recommendation would probably require a MSC due to the behaviour change.

Fixes #2120

Any stronger of a recommendation would probably require a MSC due to the behaviour change. 

Fixes #2120
@turt2live turt2live requested a review from matrix-org/spec-core-team Nov 4, 2019
@turt2live turt2live requested a review from richvdh Nov 5, 2019
@richvdh
richvdh approved these changes Nov 6, 2019
Copy link
Member

richvdh left a comment

lgtm

@@ -346,7 +346,9 @@ paths:
.. Note::
Clients should consider avoiding this endpoint for URLs posted in encrypted
rooms.
rooms. Encrypted rooms often contain more sensitive information the users

This comment has been minimized.

Copy link
@richvdh

richvdh Nov 6, 2019

Member

I would simply have said "... to avoid leaking URLs to the homeserver", but this is fine.

This comment has been minimized.

Copy link
@turt2live

turt2live Nov 6, 2019

Author Member

fair, I'm a verbose person :|

@turt2live turt2live merged commit 8e6e47a into master Nov 6, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #1002 passed (1 minute, 7 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
@turt2live turt2live deleted the travis/spec/fix-2120 branch Nov 6, 2019
@jplatte jplatte referenced this pull request Nov 14, 2019
1 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.