MSC3254: Add "knock" membership to /members filters #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
changed the title
jaller94
changed the title
|
This does look like an oversight in the MSC, and may require another MSC to rectify. |
anoadragon453
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
Scratch my above comment. I chatted with other members of the Spec Core Team and we agree that this is an obvious consequence of #2403, and the update is so small as not to warrant a new MSC over it.
As for the code, it looks good to me! Thanks for catching it.
(For reference, Synapse's implementation already accepts knock on this endpoint.)
richvdh
pushed a commit
that referenced
this pull request
Aug 23, 2021
richvdh
pushed a commit
that referenced
this pull request
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume it's an oversight that the filters of
GET /_matrix/client/r0/rooms/{roomId}/membersdoesn't include"knock"as a possible membership state.The response format lists knock as a possible value because it's referencing MemberEvent.