Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3604: Room Version 10 #3604

Merged
merged 7 commits into from
May 29, 2022
Merged

MSC3604: Room Version 10 #3604

merged 7 commits into from
May 29, 2022

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Dec 29, 2021 •
edited
Loading

@turt2live turt2live added blocked Something needs to be done before action can be taken on this PR/issue. kind:core MSC which is critical to the protocol's success proposal A matrix spec change proposal room-spec Something to do with the room version specifications labels Dec 29, 2021
@turt2live turt2live mentioned this pull request Dec 29, 2021
Closed
4 tasks
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Dec 31, 2021
@neilalexander
Copy link
Contributor

Can I propose adding #3667? Seems like a good bug fix to get in.

Mikaela
Mikaela reviewed Feb 3, 2022
View reviewed changes
proposals/3604-rooms-v10.md Outdated Show resolved Hide resolved
@Mikaela Mikaela mentioned this pull request Feb 21, 2022
Closed
@turt2live turt2live mentioned this pull request Mar 25, 2022
Open
@turt2live turt2live mentioned this pull request May 4, 2022
Closed
@turt2live turt2live removed blocked Something needs to be done before action can be taken on this PR/issue. needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels May 4, 2022
@turt2live turt2live changed the title [WIP: Not ready for review/impl] MSC3604: Room Version 10 MSC3604: Room Version 10 May 4, 2022
@turt2live turt2live mentioned this pull request May 4, 2022
Merged
@turt2live
Copy link
Member Author

This MSC is now ready for review. Once MSC3787 clears FCP (or reasonably looks like it will clear FCP), this MSC will be sent up for FCP.

@turt2live turt2live marked this pull request as ready for review May 4, 2022 03:10
@turt2live turt2live added this to Needs idea feedback / initial review in Spec Core Team Backlog via automation May 4, 2022
@turt2live turt2live moved this from Needs idea feedback / initial review to Proposed for FCP readiness in Spec Core Team Backlog May 4, 2022
This was referenced May 4, 2022
Merged
Merged
turt2live
turt2live commented May 4, 2022
View reviewed changes
proposals/3604-rooms-v10.md Outdated Show resolved Hide resolved
@mscbot mscbot added the final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. label May 24, 2022
@richvdh richvdh moved this from Ready for FCP ticks to In FCP in Spec Core Team Backlog May 24, 2022
@turt2live turt2live added this to Needs Spec PR in Matrix 1.3 hitlist via automation May 24, 2022
@turt2live turt2live self-assigned this May 24, 2022
@turt2live turt2live moved this from Needs Spec PR to Spec PR in progress in Matrix 1.3 hitlist May 24, 2022
@mscbot
Copy link
Collaborator

mscbot commented May 29, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels May 29, 2022
@turt2live turt2live merged commit 46ae237 into main May 29, 2022
@turt2live turt2live deleted the travis/msc/v10 branch May 29, 2022 16:07
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels May 29, 2022
@turt2live turt2live moved this from In FCP to Done to some definition in Spec Core Team Backlog May 29, 2022
@neilalexander neilalexander mentioned this pull request May 30, 2022
Merged
@turt2live turt2live mentioned this pull request May 30, 2022
Merged
@turt2live
Copy link
Member Author

Spec PR: matrix-org/matrix-spec#1099

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 30, 2022
@turt2live turt2live moved this from Spec PR in progress to Spec PR needs review in Matrix 1.3 hitlist May 30, 2022
@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 8, 2022
@turt2live
Copy link
Member Author

Merged 🎉

@turt2live turt2live moved this from Spec PR needs review to Merged to spec (done) in Matrix 1.3 hitlist Jun 8, 2022
This was referenced Jun 10, 2022
Closed
Closed
This was referenced Jun 21, 2022
Merged
Merged
@anoadragon453 anoadragon453 restored the travis/msc/v10 branch September 27, 2022 16:59
@S7evinK S7evinK mentioned this pull request Sep 29, 2023
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikaela Mikaela Mikaela left review comments

@jplatte jplatte jplatte left review comments

Assignees

@turt2live turt2live

Labels
kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal room-spec Something to do with the room version specifications
Projects
Spec Core Team Backlog
Archived in project
Matrix 1.3 hitlist
Merged to spec (done)
Spec Core Team Backlog
  
Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@turt2live @neilalexander @mscbot @Mikaela @jplatte