UI Auth: servers should 401 when a request fails #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
approved these changes
Oct 5, 2016
richvdh
added a commit
to matrix-org/synapse
that referenced
this pull request
Oct 11, 2016
5d9546f introduced a change to synapse behaviour, in that failures in the interactive-auth process would return the flows and params data as well as an error code (as specced in matrix-org/matrix-spec-proposals#397). That change exposed a bug in Riot which would make it request a new validation token (and send a new email) each time it got a 401 with a `flows` parameter (see element-hq/element-web#2447 and the fix at matrix-org/matrix-react-sdk#510). To preserve compatibility with broken versions of Riot, grandfather in the old behaviour for the email validation stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(ref https://matrix.org/jira/browse/SYN-744)
Also remove the thing about weak passwords from m.login.password. If the user has set a weak password, it's not very helpful to reject their login because of it.