Do not explicitly pass --target to rustup #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem to be necessary to install Rust. Passing `--target` prevents the Dockerfile from being built on different architectures. Not passing it makes it auto-detect what to install. Discussed here: spantaleev/matrix-docker-ansible-deploy#1505
27 tasks
|
I can't remember why we did this initially, it might well have been my fruitless efforts to use Rust with alpine. |
|
@spantaleev Can I have a synapse-style changelog entry just describing what this does? |
|
I've added a changelog entry. I hope it's all good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem to be necessary to install Rust.
Passing
--targetprevents the Dockerfile from being built on different architectures.Not passing it makes it auto-detect what to install.
Actually, I've managed to build this Dockerfile on ARM64 even with the hardcoded
--target. It's misleading though, so removing it is better.Discussed here: spantaleev/matrix-docker-ansible-deploy#1505