Made ESLint lint all TypeScript files and fix a few linter errors #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
approved these changes
Apr 4, 2022
Half-Shot
requested changes
Apr 4, 2022
added 6 commits
April 4, 2022 13:44
…kshot into j94/unused-imports
jaller94
changed the title
jaller94
commented
Apr 4, 2022
jaller94
commented
Apr 4, 2022
Comment on lines
+49
to
+52
| "no-unused-vars": "off", | ||
| "@typescript-eslint/no-unused-vars": ["error"], | ||
| "no-useless-constructor": "off", | ||
| "@typescript-eslint/no-useless-constructor": ["error"], |
There was a problem hiding this comment.
I couldn't figure out why the regular eslint rules were still being used.
Only the TypeScript variants make sense for this code base.
There was a problem hiding this comment.
Hm, suppose we can come back to this one when it poses a problem for us. The linter seems happy for the moment.
Half-Shot
approved these changes
Apr 5, 2022
Comment on lines
+49
to
+52
| "no-unused-vars": "off", | ||
| "@typescript-eslint/no-unused-vars": ["error"], | ||
| "no-useless-constructor": "off", | ||
| "@typescript-eslint/no-useless-constructor": ["error"], |
There was a problem hiding this comment.
Hm, suppose we can come back to this one when it poses a problem for us. The linter seems happy for the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.json. Currently,*.tsfiles directly in thesrcfolder are not linted on all operating systems because**resolves to folder names.testandwebfolder with slightly adapted rules.