Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically define connection creation and provisioing #330

Merged
merged 11 commits into from
May 6, 2022

Conversation

Half-Shot
Copy link
Contributor

This aims to nearly remove all burden on developers to modify anything outside their connection class when adding new connections. When creating a connection, developers now define their provisioning and creation functions as static functions on their connection class.

Connections can be added by simply adding a @Connection decorator.

@Connection
export class YourConnection {
....
}

@Half-Shot Half-Shot marked this pull request as ready for review May 4, 2022 13:40
@Half-Shot Half-Shot requested a review from tadzik May 4, 2022 14:12
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge +1 from me :) Few nitpicks.

src/Bridge.ts Outdated Show resolved Hide resolved
src/Bridge.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

­

@Half-Shot Half-Shot requested a review from tadzik May 6, 2022 13:25
@Half-Shot Half-Shot force-pushed the hs/refactor-connection-manager-handling branch from 3f05c6c to 8ecd15b Compare May 6, 2022 13:35
@Half-Shot Half-Shot enabled auto-merge (squash) May 6, 2022 13:54
@Half-Shot Half-Shot force-pushed the hs/refactor-connection-manager-handling branch from 8ecd15b to b19cc56 Compare May 6, 2022 13:55
@Half-Shot Half-Shot merged commit b23e516 into main May 6, 2022
@Half-Shot Half-Shot deleted the hs/refactor-connection-manager-handling branch May 6, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants