Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Admin command from listing and disconnecting connections #367

Merged
merged 11 commits into from Jun 8, 2022
Merged

Add Admin command from listing and disconnecting connections #367

merged 11 commits into from Jun 8, 2022

Conversation

tadzik
Copy link
Contributor

@tadzik tadzik commented Jun 6, 2022 •
edited by Half-Shot

(Only lists Github for now).

image

tadzik
tadzik commented Jun 6, 2022
View reviewed changes
src/AdminRoom.ts Show resolved Hide resolved
@Half-Shot Half-Shot self-requested a review June 6, 2022 08:26
Half-Shot
Half-Shot reviewed Jun 6, 2022
View reviewed changes
src/Bridge.ts Outdated Show resolved Hide resolved
Half-Shot
Half-Shot reviewed Jun 6, 2022
View reviewed changes
src/AdminRoom.ts Outdated Show resolved Hide resolved
Half-Shot
Half-Shot requested changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bit more thought but on the right track

@tadzik
Require connectionManager permissions to manipulate connections
8842b89 
Gives connection management its own config section and switches
AdminRoom categories to be enums.
@tadzik
Fail more descriptively if connectionManager is not up in time for ad…
b27e965 
…minRoom
Half-Shot
Half-Shot reviewed Jun 6, 2022
View reviewed changes
src/AdminRoom.ts Outdated Show resolved Hide resolved
tadzik and others added 5 commits June 8, 2022 16:26
@tadzik @Half-Shot
Fix Github API URLs (#366)
f774db1 
* Fix Github API URLs

* Add changelog entry

* Fixes

* Tidyup

Co-authored-by: Will Hunt <will@half-shot.uk>
Co-authored-by: Tadeusz Sośnierz <tadeusz@sosnierz.com>
@Half-Shot
Fix URLs *again*
efa337f
@Half-Shot
Block private repos from being publically bridged
993046b
@Half-Shot
Ensure check looks at service type
b09e377
@Half-Shot
Finish up deleting connections impl
25fe1d4
@Half-Shot Half-Shot enabled auto-merge (squash) June 8, 2022 15:26
@Half-Shot Half-Shot merged commit 86b9a83 into main Jun 8, 2022
@Half-Shot Half-Shot deleted the tadzik/listing-and-disconnecting branch June 8, 2022 15:50
@Half-Shot Half-Shot mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tadzik @Half-Shot