New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip GitLab MR reply comments #536
Conversation
145cba7
to
efed24d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I'm a bit surprised that Hookshot depends on @alloc/quick-lru
instead of the upstream quick-lru
(which became an ESM in version 6).
Co-authored-by: Christian Paul <christianp@matrix.org>
Co-authored-by: Christian Paul <christianp@matrix.org>
Co-authored-by: Christian Paul <christianp@matrix.org>
We can't use ESM, as it introduces a bunch of annoying incompatibilities. Instead of trying to refactor the entire project to be ESM compatible, we've settled for just using a cJS library for the moment. |
GitLab uses
discussion_id
to chain together replies. We can't really tell what position we are in the thread, so we just have to assume that if we've not seen the discussion before that we are the first note, and subsequent notes are child notes.This also changes the code so that we skip sending a notice into the room if the user has disabled comment-only notices.