Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sucessfully #869

Merged
merged 2 commits into from
Dec 29, 2023
Merged

sucessfully #869

merged 2 commits into from
Dec 29, 2023

Conversation

tsimonq2
Copy link
Contributor

@tsimonq2 tsimonq2 commented Dec 28, 2023 •
edited

@tsimonq2 tsimonq2 requested a review from a team as a code owner December 28, 2023 20:32
Half-Shot
Half-Shot approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I should really run a spell checker on some of these strings :)

@Half-Shot
Copy link
Contributor

@tsimonq2 would you mind doing a signoff?

@tsimonq2
Copy link
Contributor Author

@Half-Shot Not a problem! Are you looking for a signed-off-by line or a signed commit?

Simon Quigley tsimonq2@ubuntu.com works for the former (or pick any other email address from my Launchpad profile)

@tsimonq2
Copy link
Contributor Author

In case I lose track of this today, I, Simon Quigley explicitly agree to contribute my code under the existing Matrix license: https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off

@Half-Shot
Copy link
Contributor

Perfectly valid thanks!

@Half-Shot Half-Shot added this pull request to the merge queue Dec 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 29, 2023
@Half-Shot Half-Shot merged commit 3af2aa7 into matrix-org:main Dec 29, 2023
11 of 12 checks passed
Half-Shot added a commit that referenced this pull request Jan 2, 2024
@Half-Shot
5.1.2
0175f9e 
Bugfixes
--------

- Fix widget pinning to light theme. ([\#873](#873))
- Fix hookshot failing to format API errors.
  Only log a stacktrace of API errors on debug level logging, log limited error on info. ([\#874](#874))
- Fix GitHub events not working due to verification failures. ([\#875](#875))

Internal Changes
----------------

- Fix spelling of "successfully". ([\#869](#869))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsimonq2 @Half-Shot