Fix GitHub events not verifying #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
added a commit
that referenced
this pull request
Jan 2, 2024
Bugfixes -------- - Fix widget pinning to light theme. ([\#873](#873)) - Fix hookshot failing to format API errors. Only log a stacktrace of API errors on debug level logging, log limited error on info. ([\#874](#874)) - Fix GitHub events not working due to verification failures. ([\#875](#875)) Internal Changes ---------------- - Fix spelling of "successfully". ([\#869](#869))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point the API on the @octokit/webhooks library changed and it started requiring a full raw payload of the JSON data rather than a parsed body. To get around this, we store the raw string value of the body on the request object after verifying that the fields are valid.
Ideally we'd validate in the verification function, but alas the GitHub function is async and the verifier expects a synchronous throw.