Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary forced keys/query in triggerComputeTrust of MXRoomSummary #1669

Open
BillCarsonFr opened this issue Dec 19, 2022 · 0 comments
Open
Assignees
Labels

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Dec 19, 2022

MXRoomSummary will force download all keys of room members for no reason.
Triggerd on init, Can be trigger when member count change and some other triggers.

There is no real reason for MXRoomSummary to do that, it should compute trust without forcing key downloads.
The keys should already be downloaded:

  • When a members join an encrypted, his keys will be tracked
  • When loading members of a lazy loading the member's devices will be tracked
  • when setting encryption.

Would be probably better to listen to MXDeviceListDidUpdateUsersDevicesNotification and then if one of the member is present in the change list to then compute trust (with force download = false)

@BillCarsonFr BillCarsonFr self-assigned this Dec 19, 2022
@BillCarsonFr BillCarsonFr assigned Anderas and unassigned Anderas and BillCarsonFr Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants