Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoV2 is not tracking users on membership changes, and only querying keys for unknown users if forceDownload is true #1670

Closed
BillCarsonFr opened this issue Dec 20, 2022 · 0 comments · Fixed by #1676
Assignees
Labels

Comments

@BillCarsonFr
Copy link
Member

MXCryptoV2 is not listening to room membership events of encrypted rooms in order to start tracking their devices (ask olmMachine to query keys).
That is problematic if computeE2ERoomSummaryTrust is FALSE, as the keys will be downloaded later when sending a message, and that could affect message sending time.

Also MXCryptoV2.downloadKeys looks like it's not behaving as expected?
If forceDownload is false, it will only return keys in cache.
It should in this case check what keys are missing from the provided user list, and only querying for them and return the newly downloaded one + the one that are already in cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants