Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK uses console.log in some places when client is accessible #1435

Closed
KB1RD opened this issue Aug 4, 2020 · 1 comment
Closed

SDK uses console.log in some places when client is accessible #1435

KB1RD opened this issue Aug 4, 2020 · 1 comment

Comments

@KB1RD
Copy link

KB1RD commented Aug 4, 2020

This means that some entries do not go through the loglevel logger as expected. (See this search) Should ESLint be configured to warn about console usage?

I'd be happy to make a PR; I'd just like to know if I should reconfigure ESLint.
@clokep clokep mentioned this issue Sep 9, 2021
Closed
@richvdh
Copy link
Member

richvdh commented Oct 9, 2023

ESlint does warn about console usage nowadays, and the search returns no hits, so I think this is fixed.

@richvdh richvdh closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @KB1RD