Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-browserify.spec.js failing if yarn build isn't run #1656

Closed
germain-gg opened this issue Apr 6, 2021 · 2 comments
Closed

sync-browserify.spec.js failing if yarn build isn't run #1656

germain-gg opened this issue Apr 6, 2021 · 2 comments

Comments

@germain-gg
Copy link
Contributor

Describe the bug

sync-browserify.spec.js requires a prior call to yarn build in order to pass

To Reproduce

  1. Clone the repo
  2. Run yarn && yarn test

Expected behavior

For all tests in sync-browserify.spec.js to pass

Actual behavior

The sync-browserify.spec.js file fails because it imports ../../dist/browser-matrix. That file is generated after a run to yarn build

@jryans
Copy link
Collaborator

jryans commented Apr 7, 2021

Hmm, yeah that's a tricky one... 🤔 In some ways, that test is checking for "is the browser build importable", so we'd at least need to build it... I wouldn't want to forcing building on every test run though... maybe documentation is the answer?

@t3chguy
Copy link
Member

t3chguy commented Oct 31, 2023

The browserify stuff is gone

@t3chguy t3chguy closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants