Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to CryptoStores for migration to Rust Crypto #3963

Closed
richvdh opened this issue Dec 15, 2023 · 0 comments · Fixed by #3969
Closed

Add support to CryptoStores for migration to Rust Crypto #3963

richvdh opened this issue Dec 15, 2023 · 0 comments · Fixed by #3969
Assignees

Comments

@richvdh
Copy link
Member

richvdh commented Dec 15, 2023

To support migration to Rust Crypto, I think we need to add a bunch of methods to the legacy CryptoStore implementations (all three of them, though MemoryStore will be a no-op):

  • containsData: unlike the other methods, needs to be callable before startup. Checks if the database might contain data that needs migration (probably via the existing exists static methods).
  • get/setMigrationState: stores/returns some integer which represents how many migration steps we have done (see Rust crypto: support migration to Rust crypto #3964). We can probably stash the data itself in the account object.
  • getEndToEndSessionsBatch, getEndToEndInboundGroupSessionsBatch: retrieve a batch of (pickled) Olm/Megolm sessions. getEndToEndInboundGroupSessionsBatch also needs to check sessions_needing_backup to see which sessions still need backup.
  • deleteEndToEndSessionsBatch, deleteEndToEndInboundGroupSessionsBatch: delete a batch of Olm/Megolm sessions. (Presumably we pass them a list of sessions?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant