Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time selector is showing for a day with less than the limit of messages #211

Closed
MadLittleMods opened this issue May 4, 2023 · 1 comment · Fixed by #213
Closed

Time selector is showing for a day with less than the limit of messages #211

MadLittleMods opened this issue May 4, 2023 · 1 comment · Fixed by #213
Assignees
@MadLittleMods
Labels
A-archive-room-view The view to look at a room day by day in the archive T-Defect Something isn't working. Bugs, crashes, or other reported issues.
Milestone
Matrix Public Arc...

Comments

@MadLittleMods
Copy link
Contributor

Time selector is showing for a day with less than the limit of messages.

It's a room with only 3 actual messages in it.
@MadLittleMods MadLittleMods added T-Defect Something isn't working. Bugs, crashes, or other reported issues. A-archive-room-view The view to look at a room day by day in the archive labels May 4, 2023
@MadLittleMods
Copy link
Contributor Author

This is just because we only care about whether the messages on the page are from the same day

https://github.com/matrix-org/matrix-public-archive/blob/9b067f8637e71992400a908eab71c1050c68be74/shared/viewmodels/ArchiveRoomViewModel.js#L144-L151

We could update to check whether events.length > archiveMessageLimit as well

@MadLittleMods MadLittleMods self-assigned this May 5, 2023
MadLittleMods added a commit that referenced this issue May 5, 2023
@MadLittleMods
Fix time selector showing when less than the page limit of messages
2fbed73 
Fix #211
@MadLittleMods MadLittleMods mentioned this issue May 5, 2023
Merged
MadLittleMods added a commit that referenced this issue May 5, 2023
@MadLittleMods
Fix time selector showing when less than the page limit of messages (#…
b108845 
…213)

Fix #211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadLittleMods MadLittleMods

Labels
A-archive-room-view The view to look at a room day by day in the archive T-Defect Something isn't working. Bugs, crashes, or other reported issues.
Projects
None yet
Milestone
Matrix Public Archive v(next)
Development

Successfully merging a pull request may close this issue.

Fix time selector showing when less than the page limit of messages matrix-org/matrix-viewer
1 participant
@MadLittleMods