Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm run build is required #212

Closed
Cyberes opened this issue May 5, 2023 · 1 comment · Fixed by #220
Closed

npm run build is required #212

Cyberes opened this issue May 5, 2023 · 1 comment · Fixed by #220
Assignees
@MadLittleMods
Labels
documentation Improvements or additions to documentation help wanted PR's welcome to fix this issue. It probably has a potential solution documented in the issue. T-Defect Something isn't working. Bugs, crashes, or other reported issues.

Comments

@Cyberes
Copy link

Cyberes commented May 5, 2023

I was updating my install and it was failing with errors involving a missing directory named dist. I ran npm run build which fixed the error. Should this be added to the readme?
@MadLittleMods MadLittleMods added T-Defect Something isn't working. Bugs, crashes, or other reported issues. documentation Improvements or additions to documentation help wanted PR's welcome to fix this issue. It probably has a potential solution documented in the issue. labels May 5, 2023
@MadLittleMods
Copy link
Contributor

MadLittleMods commented May 5, 2023 •
edited

Good find @Cyberes, thanks for trying it out! We can just add after npm install (no empty line).

$ npm install
$ npm run build

Would you be interested in creating a PR?

@MadLittleMods MadLittleMods changed the title npm build is required npm run build is required May 5, 2023
@MadLittleMods MadLittleMods self-assigned this May 5, 2023
@MadLittleMods MadLittleMods mentioned this issue May 5, 2023
Merged
MadLittleMods added a commit that referenced this issue May 5, 2023
@MadLittleMods
Various updates to put archive.matrix.org in the forefront (#220)
ed3fde7 
Fix #212

Screenshot at 90% zoom with even dimensions for better scaling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadLittleMods MadLittleMods

Labels
documentation Improvements or additions to documentation help wanted PR's welcome to fix this issue. It probably has a potential solution documented in the issue. T-Defect Something isn't working. Bugs, crashes, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various updates to put archive.matrix.org in the forefront matrix-org/matrix-viewer
2 participants
@MadLittleMods @Cyberes