Add lightbox support and Hydrogen URL hashes relative to the room #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to element-hq/hydrogen-web#677 Before: ``` <div class="Timeline_messageBody"> <div class="media" style="max-width: 400px"> <div class="spacer" style="padding-top: 48.75%;"></div> <a href="undefined" title="Friction_between_surfaces.jpeg" style="max-width: 400px; max-height: 195px;"></a><time>2/24 6:20 PM</time> </div> <!--node binding placeholder--> </div> ``` After: ``` <div class="Timeline_messageBody"> <div class="media" style="max-width: 400px"> <div class="spacer" style="padding-top: 48.75%;"></div> <a href="#/session/123/room/!HBehERstyQBxyJDLfR:my.synapse.server/lightbox/$17cgP6YBP9ny9xuU1vBmpOYFhRG4zpOe9SOgWi2Wxsk"><img src="http://192.168.1.182:8008//_matrix/media/r0/thumbnail/my.synapse.server/RxfuMxEgYcXHKYWERkKVUkqO?width=400&height=195&method=scale" alt="Friction_between_surfaces.jpeg" title="Friction_between_surfaces.jpeg" style="max-width: 400px; max-height: 195px;"></a><time>2/24 6:20 PM</time> </div> <!--node binding placeholder--> </div> ```
MadLittleMods
commented
Jun 7, 2022
This way we can get rid of the bogus session and the duplicated roomId in the URL. Example result: `http://localhost:3050/!HBehERstyQBxyJDLfR:my.synapse.server/date/2022/02/24#/lightbox/$17cgP6YBP9ny9xuU1vBmpOYFhRG4zpOe9SOgWi2Wxsk` --- Before: ``` ``` After: ``` ```
Conflicts: server/start-dev.js
MadLittleMods
changed the title
MadLittleMods
added a commit
to element-hq/hydrogen-web
that referenced
this pull request
Jun 8, 2022
Changes to go along with matrix-org/matrix-viewer#12 Split out from #653
MadLittleMods
added
the
A-archive-room-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add image lightbox support and Hydrogen URL hashes relative to the room
Related to element-hq/hydrogen-web#677
Requires the changes from element-hq/hydrogen-web#749 (split out from element-hq/hydrogen-web#653)
Hydrogen routing relative to the room (remove session and room from the URL hash)
Before:
Page URL: doesn't work
Before (not relative):
Page URL:
http://localhost:3050/!HBehERstyQBxyJDLfR:my.synapse.server/date/2022/02/24#/session/123/room/!HBehERstyQBxyJDLfR:my.synapse.server/lightbox/$17cgP6YBP9ny9xuU1vBmpOYFhRG4zpOe9SOgWi2WxskAfter (nice relative links):
Page URL:
http://localhost:3050/!HBehERstyQBxyJDLfR:my.synapse.server/date/2022/02/24#/lightbox/$17cgP6YBP9ny9xuU1vBmpOYFhRG4zpOe9SOgWi2WxskTodo
escapekeyboard shortcuts still work