Containerize app (make a Docker image for matrix-public-archive)
#22
Conversation
MadLittleMods
added
the
T-Task
| - name: Extract metadata (tags, labels) for Docker | ||
| id: meta | ||
| uses: docker/metadata-action@98669ae865ea3cffbcbaa878cf57c20bbf1c6c38 | ||
| with: | ||
| images: ${{ steps.save_var.outputs.docker_image_name }} | ||
| # Defaults (as indicated by https://github.com/docker/metadata-action/tree/97c170d70b5f8bfc77e6b23e68381f217cb64ded#tags-input). | ||
| # Plus custom tags: | ||
| # - Full length sha | ||
| tags: | | ||
| type=schedule | ||
| type=ref,event=branch | ||
| type=ref,event=tag | ||
| type=ref,event=pr | ||
| type=sha,format=long |
There was a problem hiding this comment.
Re-introducing the docker/metadata-action so that we get nice tags for PRs, branches, and tags. It just does the right thing.
We additionally added type=sha,format=long the default list of tags so that we can still reference it in services below. The only change is that it uses the sha-xxx prefix for the commit sha tags.
| @@ -47,21 +47,36 @@ jobs: | |||
| # the next job. | |||
| # | |||
| # via https://github.community/t/how-to-use-env-with-container-image/17252/25 | |||
| - name: Save the Docker image name to a variable so we can share and re-use it in other jobs via `${{ needs.deploy-test-synapse-image.outputs.docker_image_name }}` | |||
| - name: Save the Docker image name to a variable so we can share and re-use it in other jobs via `${{ needs.build-test-synapse-image.outputs.docker_image_name }}` | |||
There was a problem hiding this comment.
Removing the tag from the end of the name so that we can re-use it in the metadata action.
We now specify this explicitly set this in the services which still works 🤷
|
|
||
| # loggers: | ||
| # synapse.rest.media.v1.thumbnail_resource: | ||
| # level: DEBUG |
There was a problem hiding this comment.
This isn't really related to this PR but was messing around with this on matrix-org/synapse#13016 and matrix-org/synapse#13039 and thought it was good reference whenever we want to add logging for something else down the line. Saves me from looking it up to copy-paste.
Containerize app (make a Docker image for
matrix-public-archive)... with a variety of tags!
Dev notes