Skip to content
This repository has been archived by the owner on Jul 5, 2022. It is now read-only.

Binaries aren't built for non-standard platforms when pulled from NPM #6

Open
Half-Shot opened this issue May 6, 2022 · 1 comment

Comments

@Half-Shot
Copy link

https://github.com/matrix-org/matrix-rust-sdk-bindings/blob/main/crates/matrix-sdk-crypto-nodejs/check-exists.js supposedly should be attempting to build fresh binaries if the existing ones do not load properly, but in practise it seems like this check is being missed. We have a person trying to use matrix-hookshot on arm64 linux but finding that they only have

index.linux-ia32-gnu.node
index.linux-x64-gnu.node

built, which seems surprising on a arm architecture. I would imagine the error checking code in check-exists is not sufficient, as the error they are reporting is:

May 06 11:31:42 ocfree2 systemd[1]: Started A bridge between Matrix and multiple project management services, such as GitHub, GitLab and JIRA..
May 06 11:31:43 ocfree2 matrix-hookshot[1378257]: /bin/matrix-hookshot/node_modules/@turt2live/matrix-sdk-crypto-nodejs/lib/napi-module.js:208
May 06 11:31:43 ocfree2 matrix-hookshot[1378257]:     throw loadError
May 06 11:31:43 ocfree2 matrix-hookshot[1378257]:     ^
May 06 11:31:43 ocfree2 matrix-hookshot[1378257]: Error: Cannot find module '@turt2live/matrix-sdk-crypto-nodejs-linux-arm64-gnu'
May 06 11:31:43 ocfree2 matrix-hookshot[1378257]: Require stack:
@turt2live
Copy link
Member

If the package manager fails to build the arm-specific bindings then it still continues with package install, annoyingly. Check earlier logs to see if the build failed or was incomplete.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants