Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFI: BackupDownloadStrategy cannot be set in ClientBuilder #3130

Closed
kegsay opened this issue Feb 14, 2024 · 1 comment · Fixed by #3131 or #3326
Closed

FFI: BackupDownloadStrategy cannot be set in ClientBuilder #3130

kegsay opened this issue Feb 14, 2024 · 1 comment · Fixed by #3131 or #3326
Labels
bug Something isn't working encryption

Comments

@kegsay
Copy link
Member

kegsay commented Feb 14, 2024

The client_builder used to set the BackupDownloadStrategy to AfterDecryptionFailure which was a sensible default. In the refactoring in #3115 this changed, and the default now fell to the value in the enum which is Manual. I don't think this is a sensible default.

This is made worse by the fact that it's impossible to change this value now, because FFI bindings aren't created for pub(crate) fn with_encryption_settings(...) due to visibility rules.

The net result is that key backup downloading is broken on latest main EDIT: if you use the authentication service then the right defaults are set. This only applies when you use client_builder directly.

@bnjbvr
Copy link
Member

bnjbvr commented Feb 15, 2024

Reopening: #3131 was a quick workaround, but it's still not possible to set it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working encryption
Projects
None yet
2 participants