Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m.key.verification.accept should not have a 'method' field #2651

Closed
uhoreg opened this issue Jun 21, 2020 · 3 comments · Fixed by #2653
Closed

m.key.verification.accept should not have a 'method' field #2651

uhoreg opened this issue Jun 21, 2020 · 3 comments · Fixed by #2653
Labels
client-server Client-Server API e2e spec-bug Something which is in the spec, but is wrong

Comments

@uhoreg
Copy link
Member

uhoreg commented Jun 21, 2020

probably a copy-and-paste error. It wasn't in the original MSC, and doesn't really make sense to be there since the method is already determined at that point.

@turt2live turt2live added client-server Client-Server API e2e spec-bug Something which is in the spec, but is wrong labels Jun 21, 2020
@Dominaezzz
Copy link
Contributor

Related matrix-org/matrix-js-sdk#1390 and element-hq/element-android#1433 . Seems to be ignored anyway.

If it makes a difference, I think the method field can help with polymorphic serialization in strongly typed languages.

@Dominaezzz
Copy link
Contributor

Dominaezzz commented Jun 24, 2020

Does this mean m.sas.v1 is going to be the only type of verification ever?

EDIT: Or rather, the only kind of verification you can accept?

@uhoreg
Copy link
Member Author

uhoreg commented Jun 24, 2020

Currently, m.sas.v1 is the only method that uses the m.key.verification.accept event. In theory, other methods might in the future, but there are currently no plans for any other methods. The method is already specified in the m.key.verification.start message, so it's not needed in m.key.verification.accept, because the m.key.verification.accept is already linked to the m.key.verification.start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API e2e spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants