Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m.fully_read example is misleading #3183

Closed
zecakeh opened this issue May 8, 2021 · 0 comments · Fixed by #3679
Closed

m.fully_read example is misleading #3183

zecakeh opened this issue May 8, 2021 · 0 comments · Fixed by #3679
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@zecakeh
Copy link
Contributor

zecakeh commented May 8, 2021

Link to problem area: https://matrix.org/docs/spec/client_server/r0.6.1#m-fully-read

Issue
The example in this area is misleading because it shows the event with a room_id key, but it should never be received like that because in the sync response it's received inside a Joined Room > Account Data object, and if you call the room account data endpoint you only receive the content.

Expected behaviour
This should be the example provided, similar to m.tag, as one would receive it in the sync response:

{
    "content": {
        "event_id": "$someplace:example.org"
    },
    "type": "m.fully_read"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
1 participant