Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed rst->md numbered list syntax for m.room.server_acl #3681

Merged
merged 3 commits into from Feb 6, 2022

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jan 27, 2022

There was some left-over RST syntax which was causing a numbered list to have broken formatting:

image

This PR applies the equivalent markdown syntax.

Preview: https://pr3681--matrix-org-previews.netlify.app

@anoadragon453 anoadragon453 requested a review from a team January 27, 2022 15:09
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does exactly what it says on the box.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please can we use real numbers and not markdown trickery

@anoadragon453
Copy link
Member Author

please can we use real numbers and not markdown trickery

Oh, why do you prefer real numbers? I find the advantage of this is that items can be added to the list without having to reflow the numbers.

@turt2live
Copy link
Member

It's so that the raw markdown can theoretically be used as a reference without the HTML rendering, and to make review easier down the line when we say "Rule 4 is changed"

@anoadragon453
Copy link
Member Author

Thank you, I hadn't considered those points. That sounds like reason enough to change it.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

This should also get a typos changelog (copy/paste from an existing one)

@turt2live
Copy link
Member

oh, it has a changelog and I'm blind.

@uhoreg uhoreg merged commit e7adfd5 into main Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants