Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in end_to_end_encryption.md #3708

Merged
merged 2 commits into from Feb 22, 2022
Merged

Fix broken link in end_to_end_encryption.md #3708

merged 2 commits into from Feb 22, 2022

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Feb 3, 2022

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you get a chance, can we get a "Fix various typos throughout the specification." changelog entry for this please?

If not, I'll add it in when merging.

@turt2live turt2live self-requested a review February 5, 2022 02:16
@jplatte
Copy link
Contributor Author

jplatte commented Feb 8, 2022

How do I do that, actually? I see there's a changelogs directory, but it's per-spec (client_server, server_server, ..) and per-issue while it sounds like you want me to add some sort of catch-all thing where the next typo fix will be referenced as well rather than being its own changelog entry.

@uhoreg
Copy link
Member

uhoreg commented Feb 8, 2022

You can just create a file in changelogs/client_server/newsfragments, named after the PR number and change type (in this case, the file would be named 3708.clarification), containing the exact text that Travis wrote in his comment. The idea is that if we use that text for all the typo correction PRs, our changelog tool will notice that multiple PRs have the same text and will lump them all together in one entry, rather than giving each one their own entry. (At least, that's how it used to work -- the new changelog doesn't seem to do that any more. ☹️ )

@richvdh
Copy link
Member

richvdh commented Feb 22, 2022

changelog added in 4ab9286

(At least, that's how it used to work -- the new changelog doesn't seem to do that any more. frowning_face )

It should do - citation needed?

@richvdh richvdh merged commit d7d52e8 into matrix-org:main Feb 22, 2022
@jplatte jplatte deleted the patch-1 branch February 22, 2022 18:24
@uhoreg
Copy link
Member

uhoreg commented Feb 23, 2022

(At least, that's how it used to work -- the new changelog doesn't seem to do that any more. frowning_face )

It should do - citation needed?

On https://spec.matrix.org/v1.2/changelog/ for "Changes since last release", I see things like:

image

where it has one line per PR, whereas for the v1.1 changes, I see:

image

one line for 3 PRs

@richvdh
Copy link
Member

richvdh commented Feb 23, 2022

thanks. opened as #3742

RiotTranslateBot pushed a commit to RiotTranslateBot/matrix-doc that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants