Fix m.login.appservice -> m.login.application_service #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementations seem to agree with the proposal, so I'd suggest we fix the typo in the spec. I don't *think* this needs a MSC as the original proposal was fine, and this was just a copy error.
anoadragon453
requested changes
Feb 7, 2022
There was a problem hiding this comment.
I don't see any mention of m.login.appservice across GitHub (https://cs.github.com/?scopeName=All+repos&scope=&q=%22m.login.appservice%22) other than matrix-doc (this repo) and matrix.org (the v1.2 blogpost). Checking Conduit, FluffyChat and the Beeper group over on GitLab also yields only results for the correct identifier.
As such, I'm satisfied that implementations look to have done the right thing, and that this typo can just be fixed without an MSC.
turt2live
reviewed
Feb 14, 2022
Co-authored-by: Travis Ralston <travisr@matrix.org>
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3709
Implementations seem to agree with the proposal, so I'd suggest we fix the typo in the spec. I don't think this needs a MSC as the original proposal was fine, and this was just a copy error.
I didn't update the changelog file for v1.2, but can do if requested.
Preview: https://pr3711--matrix-org-previews.netlify.app