MSC4117: Reinstating Events (Reversible Redactions) #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
changed the title
turt2live
added
proposal
turt2live
commented
Mar 4, 2024
There was a problem hiding this comment.
Implementation requirements:
- Recommended to wait until the MSC settles a bit before implementation begins.
turt2live
commented
Mar 4, 2024
Comment on lines
+323
to
+325
| > **TODO**: This^ is a massive problem because Synapse populates `depth` on events still, which serves | ||
| > no purpose and is an unprotected field. To make this proposal work in all existing room versions, | ||
| > and ideally with older events too, this proposal needs to handle top-level fields too. |
There was a problem hiding this comment.
"unprotected field" I think is a lie. The spec clearly still protects it, and it's marked as required on the PDU. How the field is used is unclear to me though, and I think it might be safe to remove.
See https://spec.matrix.org/v1.9/rooms/v11/#redactions
See https://spec.matrix.org/v1.9/rooms/v11/#event-format-1
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
In line with matrix-org/matrix-spec#1700, the following disclosure applies:
I am Director of Standards Development at The Matrix.org Foundation C.I.C., Matrix Spec Core Team (SCT) member, employed by Element, and operate the t2bot.io service. This proposal is written and published under my Element hat as a member of the Trust & Safety team, allocated to the Foundation.