Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error code typo #1059

Merged
merged 2 commits into from May 11, 2022
Merged

Fix error code typo #1059

merged 2 commits into from May 11, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 11, 2022 •
edited by github-actions bot

@t3chguy t3chguy requested a review from a team as a code owner May 11, 2022 07:17
@KitsuneRal
Copy link
Member

Is it also the way things are implemented in Element and elsewhere?

@t3chguy
Copy link
Member Author

t3chguy commented May 11, 2022

Element Desktop + Element Web + Matrix React SDK + Matrix JS SDK have 0 references to M_INVALID_PARAMETER and 0 references to M_INVALID_PARAM

Synapse has 3 results for PARAM https://github.com/matrix-org/synapse/search?q=M_INVALID_PARAM
and 0 results for PARAMETER https://github.com/matrix-org/synapse/search?q=M_INVALID_PARAMETER

@turt2live turt2live merged commit 573dbb3 into matrix-org:main May 11, 2022
@t3chguy t3chguy deleted the patch-1 branch May 11, 2022 17:20
@zecakeh zecakeh mentioned this pull request May 28, 2022
Closed
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t3chguy @KitsuneRal @turt2live