Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the response body/status of /invite when the user is already invited #1083

Closed
Half-Shot opened this issue May 25, 2022 · 0 comments · Fixed by #1084
Closed

Clarify the response body/status of /invite when the user is already invited #1083

Half-Shot opened this issue May 25, 2022 · 0 comments · Fixed by #1084
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@Half-Shot
Copy link
Contributor

Link to problem area: https://spec.matrix.org/v1.2/client-server-api/#post_matrixclientv3roomsroomidinvite

Issue

When a user is invited to the room (via /invite) while already being invited to the room, it's not clear from the spec on /invite what should happen. I couldn't see any text on https://spec.matrix.org/latest/client-server-api/#room-membership on what happens if a user transitions from the same state to the same state either.

Currently, Synapse will just return an empty response body as if you had invited a non-invited user. However, it would be worth clarifying that the endpoint is expected to do that to avoid relying on undefined behaviour.

@Half-Shot Half-Shot added the clarification An area where the expected behaviour is understood, but the spec could do with being more explicit label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
1 participant