Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth rule for restricted joins suggests an event should be signed by a user #1092

Closed
DMRobertson opened this issue May 27, 2022 · 1 comment · Fixed by #1093
Closed

Auth rule for restricted joins suggests an event should be signed by a user #1092

DMRobertson opened this issue May 27, 2022 · 1 comment · Fixed by #1093
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@DMRobertson
Copy link
Contributor

Link to problem area: https://spec.matrix.org/v1.2/rooms/v9/#authorization-rules

Issue

  1. If type is m.room.member:

    1. If no state_key key or membership key in content, reject.
    2. If content has a join_authorised_via_users_server key:
      1. If the event is not validly signed by the user ID denoted by the key, reject.

Emphasis mine. I think it should read "signed by the homeserver of the user ID denoted by the key".

@DMRobertson DMRobertson added the clarification An area where the expected behaviour is understood, but the spec could do with being more explicit label May 27, 2022
@turt2live
Copy link
Member

oops, yes. That would be my brain forgetting to write words it thought about.

Good spot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants