Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spaces hierarchy paramater types #1097

Merged
merged 2 commits into from
May 31, 2022

Conversation

TheOneWithTheBraid
Copy link
Contributor

@TheOneWithTheBraid TheOneWithTheBraid commented May 30, 2022

  • changed limit parameter type to integer
  • changed query parameter type to integer

A floating number does not make any sense here. Also, at least Synapse
does not allow floating point numbers in here.

Signed-off-by: TheOneWithTheBraid the-one@with-the-braid.cf

Preview: https://pr1097--matrix-spec-previews.netlify.app

@TheOneWithTheBraid TheOneWithTheBraid requested a review from a team as a code owner May 30, 2022 05:14
- changed `limit` parameter type to integer
- changed `query` parameter type to integer

A floating number does not make any sense here. Also, at least Synapse
does not allow floating point numbers in here.

Signed-off-by: TheOneWithTheBraid <the-one@with-the-braid.cf>
@turt2live turt2live merged commit 3130430 into matrix-org:main May 31, 2022
td-famedly pushed a commit to famedly/dart_matrix_api_lite that referenced this pull request Mar 22, 2024
BREAKING CHANGE (because from is now optional, so it can't be specified
conditionally)

See also:

- matrix-org/matrix-spec#1110
- matrix-org/matrix-spec#1097
td-famedly pushed a commit to famedly/dart_matrix_api_lite that referenced this pull request Mar 22, 2024
BREAKING CHANGE (because from is now optional, so it can't be specified
conditionally)

See also:

- matrix-org/matrix-spec#1110
- matrix-org/matrix-spec#1097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants