room_type is not a required parameter in practice #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice servers seem to mirror what the room create event does and leave out the room_type when unset. Signed-off-by: Nicolas Werner <n.werner@famedly.com>
Signed-off-by: Nicolas Werner <n.werner@famedly.com>
|
This seems to match the language in MSC2946:
Not sure if the server-server API doc needs to be updated too or if it re-uses this same chunk? |
|
Yeah, it also matches the spec text (which has that exact text). Didn't check the server-server API, let me do that. |
|
Yes, the server-server APi has that field as required too. It also lists allowed_roomids and such as required, which contradicts the spec text as well, let me update that. |
They are optional according to the text, but the openapi marks them as required instead. Signed-off-by: Nicolas Werner <n.werner@famedly.com>
|
Done. room_type and allowed_roomids are optional according to the text a few lines above the field marking them as required. |
Signed-off-by: Nicolas Werner <n.werner@famedly.com>
66 tasks
td-famedly
pushed a commit
to famedly/dart_matrix_api_lite
that referenced
this pull request
Mar 22, 2024
BREAKING CHANGE (because from is now optional, so it can't be specified conditionally) See also: - matrix-org/matrix-spec#1110 - matrix-org/matrix-spec#1097
td-famedly
pushed a commit
to famedly/dart_matrix_api_lite
that referenced
this pull request
Mar 22, 2024
BREAKING CHANGE (because from is now optional, so it can't be specified conditionally) See also: - matrix-org/matrix-spec#1110 - matrix-org/matrix-spec#1097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice servers seem to mirror what the room create event does and
leave out the room_type when unset.
I don't think the intention of the spec was to have the room type required
on normal rooms and the text seems to match that too.
Signed-off-by: Nicolas Werner n.werner@famedly.com
Preview: https://pr1110--matrix-spec-previews.netlify.app