Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a public room supports peeking, allow searching #1116

Open
Miepee opened this issue Jun 13, 2022 · 1 comment
Open

If a public room supports peeking, allow searching #1116

Miepee opened this issue Jun 13, 2022 · 1 comment
Labels
A-Client-Server Issues affecting the CS API improvement An idea/future MSC for the spec

Comments

@Miepee
Copy link

Miepee commented Jun 13, 2022

Is your feature request related to a problem? Please describe.
Sometimes I want to search for specific stuff in a room when peeking, without having to join it. It is already possible via peeking to get the whole room's history, so searching in there would make it easier to only get specific information.

Describe the solution you'd like
Allow searching in public rooms that support peeking.

Additional context
Was originally brought up in this issue: matrix-org/matrix-static#111
EDIT: wasn't sure whether to open the issue here, or in the matrix-spec repo.

@uhoreg uhoreg transferred this issue from matrix-org/matrix-spec-proposals Jun 13, 2022
@uhoreg
Copy link
Member

uhoreg commented Jun 13, 2022

EDIT: wasn't sure whether to open the issue here, or in the matrix-spec repo.

matrix-spec is the correct place; I've transferred the issue.

Some notes: the /search endpoint endpoint by default searches all rooms that a user is in or has been in, but you can specify a filter to limit it to certain rooms. If we do allow searching in peekable rooms, we probably don't want to make the search include all peekable rooms by default, as that could be very large. But we could make it so that if the user specifies a room (or rooms) in the filter, and the room(s) is/are peekable, then it can be searched.

@turt2live turt2live added A-Client-Server Issues affecting the CS API improvement An idea/future MSC for the spec labels Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client-Server Issues affecting the CS API improvement An idea/future MSC for the spec
Projects
None yet
Development

No branches or pull requests

3 participants