Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in m.secret.request device event name #1135

Merged
merged 4 commits into from Jul 12, 2022

Conversation

bradtgmurray
Copy link
Contributor

@bradtgmurray bradtgmurray commented Jun 16, 2022

I don't think this is supposed to be plural according to the various SDKs

Signed-off-by: Brad Murray brad@beeper.com

Preview: https://pr1135--matrix-spec-previews.netlify.app

I don't think this is supposed to be plural according to the various SDKs
@bradtgmurray bradtgmurray requested a review from a team as a code owner June 16, 2022 20:32
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only instance of it being plural in the spec - thanks!

Can we get a changelog entry for "Fix various typos throughout the specification." please?

@turt2live
Copy link
Member

@bradtgmurray are you able to add a changelog to this?

@bradtgmurray
Copy link
Contributor Author

Whoops, thanks for the reminder, done!

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@turt2live turt2live merged commit ead4375 into matrix-org:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants