Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the power levels integer range #1169

Merged
merged 6 commits into from Nov 22, 2022

Conversation

johannescpk
Copy link
Contributor

@johannescpk johannescpk commented Jul 13, 2022

To help with discussions which range of power levels are allowed. Without the clarification it's sometimes assumed that the max power level is 100.

As discussed on matrix: https://matrix.to/#/!NasysSDfxKxZBzJJoE:matrix.org/$GUmiy799UErZCQ-yi_WJS0kMNdafrjRlSYllW7fTKss?via=matrix.org&via=libera.chat&via=element.io

Signed-off-by: Johannes Becker j.becker@famedly.com

Preview: https://pr1169--matrix-spec-previews.netlify.app

@johannescpk johannescpk requested a review from a team as a code owner July 13, 2022 12:24
@johannescpk johannescpk force-pushed the power-levels-integer-range branch 3 times, most recently from 279f850 to f99eb40 Compare July 13, 2022 12:36
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking a look at this! My review is mostly nitpicky based on the surrounding spec, sorry.

data/event-schemas/schema/m.room.power_levels.yaml Outdated Show resolved Hide resolved
data/event-schemas/schema/m.room.power_levels.yaml Outdated Show resolved Hide resolved
@johannescpk johannescpk force-pushed the power-levels-integer-range branch 4 times, most recently from 1633425 to 10f9fc0 Compare July 18, 2022 17:08
Signed-off-by: Johannes Becker <j.becker@famedly.com>
Signed-off-by: Johannes Becker <j.becker@famedly.com>
Signed-off-by: Johannes Becker <j.becker@famedly.com>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you add a changelog entry? A few words in 1169.clarification in https://github.com/matrix-org/matrix-spec/tree/fad9feb80c804bc0c3d6c1cba2ee36f9be79daa2/changelogs/client_server/newsfragments will be fine.

data/event-schemas/schema/m.room.power_levels.yaml Outdated Show resolved Hide resolved
Signed-off-by: Johannes Becker <j.becker@famedly.com>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry this took so long.

@richvdh richvdh merged commit b2c4abf into matrix-org:main Nov 22, 2022
@johannescpk johannescpk deleted the power-levels-integer-range branch November 22, 2022 16:22
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
Signed-off-by: Johannes Becker <j.becker@famedly.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants