Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a stray fullstop in "Other error codes" #1180

Merged
merged 3 commits into from Jul 25, 2022
Merged

Remove a stray fullstop in "Other error codes" #1180

merged 3 commits into from Jul 25, 2022

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Jul 21, 2022 •
edited by github-actions bot

This has also been irritating me for ages

Preview: https://pr1180--matrix-spec-previews.netlify.app

@DMRobertson DMRobertson requested a review from a team as a code owner July 21, 2022 17:48
uhoreg
uhoreg approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, aside from a change to the changelog entry. Using that changelog entry means that it will get merged with other typo-fix (and similar) entries in the changelog, rather than having a whole bunch of individual changes in the list.

changelogs/client_server/newsfragments/1180.clarification Outdated Show resolved Hide resolved
@DMRobertson @uhoreg
Update changelogs/client_server/newsfragments/1180.clarification
077f414 
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
@uhoreg uhoreg merged commit 119197e into matrix-org:main Jul 25, 2022
@zecakeh zecakeh mentioned this pull request Sep 4, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DMRobertson @uhoreg